Bug #7696

Better scaling of diagrams rendered into SVG part. 2

Added by Jani Simomaa 4 months ago. Updated about 1 month ago.

Status:FeedbackStart date:2017-12-28
Priority:4Due date:2017-12-28
Assignee:Jani Simomaa% Done:

90%

Category:-Spent time:-
Target version:2018-04
Release notes:
Tags: diagram, svg, 1.32.0
Story points-
Velocity based estimate-
ReleaseSimantics 1.32.0Release relationshipAuto

Associated revisions

Revision 40370f30
Added by Jani Simomaa 4 months ago

Move scaling of SelectionNodes to upper g-element with transform

refs #7696

Change-Id: Ibc4502c9adad9be6fb71801b042ec8464baac283

History

#1 Updated by Jani Simomaa 4 months ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 90

#2 Updated by Tuukka Lehtonen 3 months ago

Jani, Reino deemed this non-working for Sulca so it needs some work still. Perhaps you'll just need to have alternate code paths based on options or something like that.

#3 Updated by Tuukka Lehtonen 3 months ago

  • Tags set to 1.32.0, svg, diagram
  • Release set to 57

#4 Updated by Tuukka Lehtonen 3 months ago

  • Target version changed from 2017-28 to 2018-01

#5 Updated by Reino Ruusu 3 months ago

This rendering issue was reverted by commit:40370f30d373d8ad850495f100700141ff600fa3.

The Sulca-specific issue is that it uses the scaling values present in the Graphics2D object to determine font sizes, but this issue also affects org.simantics.scenegraph.g2d.nodes.SelectionNode, which uses the the Graphics2D scaling to determine the margins and line width of the selection rectangle. When global scaling is taken away from Batik's SVGGraphics2D in the SCLScenegraph class, that information no longer is available to the scene graph nodes.

This scaling issue is thus present in all Simantics products. Sulca only makes it more obvious, as its diagrams are the size of a postage stamp at scaling factor 1.

#6 Updated by Tuukka Lehtonen 3 months ago

  • Target version changed from 2018-01 to 2018-02

#7 Updated by Tuukka Lehtonen 2 months ago

  • Target version changed from 2018-02 to 2018-03

#8 Updated by Tuukka Lehtonen 2 months ago

Jani, if you have time at some point, this should be looked at.

#9 Updated by Tuukka Lehtonen about 1 month ago

  • Target version changed from 2018-03 to 2018-04

Also available in: Atom PDF