Bug #7130

Shared library export fails if a shared library is not selected

Added by Hannu Niemistö about 1 year ago. Updated 27 days ago.

Status:ClosedStart date:2018-03-07
Priority:4Due date:2018-03-21
Assignee:Tuukka Lehtonen% Done:

100%

Category:-Spent time:-
Target version:2018-04
Release notes:Shared library export wizard now allows the user to select the library to export using the read-only combo box at the top of the wizard. Also, the wizard only allows selecting shared libraries for export, not anything else. Previously this could cause export of unimportable material.
Tags: 1.32.0
Story points-
Velocity based estimate-
ReleaseSimantics 1.32.0Release relationshipAuto

Description

If shared library export is tried and no shared library is not selected, the wizard page creation fails with exception:

java.lang.RuntimeException
    at org.simantics.modeling.ui.sharedontology.wizard.SharedOntologyExportPage.initializeData(SharedOntologyExportPage.java:162)
    at org.simantics.modeling.ui.sharedontology.wizard.SharedOntologyExportPage.createControl(SharedOntologyExportPage.java:150)
    at org.eclipse.jface.wizard.WizardDialog.updateForPage(WizardDialog.java:1216)
    ...

The standard logic in export wizards is to have export target selection combo box (or similar) in the first page of the export wizard that is filled by default with the selected resource, but left empty, if the current selection does not have a matching type.

Even worse is the fact that wizard will gladly export any selection as a shared library even if the exported material is not a shared library at all.

The UI needs to fixed so that
  • the combo box at the top presents all possible shared library selection
  • the combo box only shows shared ontologies and not just any initial selection given by the user. The initial selection should be resolved to its containing index root and that should be selected if it is a shared ontology.

Associated revisions

Revision bd8834c0
Added by Tuukka Lehtonen 28 days ago

Improved usability of shared library export wizard

Now allows selection of the exported shared library from the combo box
and does not allow the user to export any model-browser-selected
resource but only shared ontologies.

refs #7130

Change-Id: I19356805e37242967cb3bec7f26bb96689248d89

Revision 614521ef
Added by Tuukka Lehtonen 28 days ago

Improved usability of shared library export wizard

Now allows selection of the exported shared library from the combo box
and does not allow the user to export any model-browser-selected
resource but only shared ontologies.

refs #7130

Change-Id: I19356805e37242967cb3bec7f26bb96689248d89
(cherry picked from commit bd8834c00c213045b3967794f5841f5f33bd809c)

Revision 4dc0b37d
Added by Tuukka Lehtonen 28 days ago

Improved usability of shared library export wizard

Now allows selection of the exported shared library from the combo box
and does not allow the user to export any model-browser-selected
resource but only shared ontologies.

refs #7130

Change-Id: I19356805e37242967cb3bec7f26bb96689248d89
(cherry picked from commit bd8834c00c213045b3967794f5841f5f33bd809c)

History

#1 Updated by Tuukka Lehtonen 28 days ago

  • Description updated (diff)

#2 Updated by Tuukka Lehtonen 28 days ago

  • Due date set to 2018-03-21
  • Target version set to 2018-04
  • Start date set to 2018-03-07

#3 Updated by Tuukka Lehtonen 28 days ago

  • Tags set to 1.32.0
  • Release set to 57

#4 Updated by Tuukka Lehtonen 28 days ago

  • Status changed from New to In Progress
  • Assignee changed from Antti Villberg to Tuukka Lehtonen

#5 Updated by Tuukka Lehtonen 27 days ago

  • Status changed from In Progress to Closed
  • % Done changed from 0 to 100
  • Release notes set to Shared library export wizard now allows the user to select the library to export using the read-only combo box at the top of the wizard. Also, the wizard only allows selecting shared libraries for export, not anything else. Previously this could cause export of unimportable material.

Also available in: Atom PDF