Task #640

Feature #2801: As a modeller, I want that model browser correctly shows the element that is currently selected

Fix graph explorer selection to work when selected data is removed

Added by Kalle Kondelin over 7 years ago. Updated over 6 years ago.

Status:ClosedStart date:
Priority:6Due date:
Assignee:Tuukka Lehtonen% Done:

100%

Category:-Estimated time:0.00 hour
Target version:-Spent time:5.00 hours
Release notes:
Remaining (hours)

Description

The selection mechanism in model browser does not work always correctly. I noticed this by creating few new models (File->New model) and then trying to delete them by keyboard delete button. The first one was deleted correctly. The selection seemed to be on the second model which was highlighted but the property view still displayed the properties of the old (deleted) model. Only after moving by arrow keys (one down) the property view was updated to show the correct properties for the selected model and the delete worked as expected.


Related issues

Related to Platform - Task #2400: Fix (huge) performance problem in GraphExplorerImpl selec... Closed

Associated revisions

Revision 21334
Added by Tuukka Lehtonen over 6 years ago

Fixed GraphExplorerImpl to keep its ISelectionProvider's selection up-to-date in cases where data used for selected tree items is removed and the same tree item is reused for different data.

fixes #640

Revision 21350
Added by Tuukka Lehtonen over 6 years ago

Still some more fixes for cases where deleted explorer nodes would selection/post-selection listeners to go out of sync. Fixed by unifying the selection reset code between cases where tree item selection changes and where logical selection changes but tree selection does not.

fixes #640

History

#1 Updated by Antti Villberg over 7 years ago

  • Status changed from New to In Progress

#2 Updated by Tuukka Lehtonen over 7 years ago

  • Due date deleted (2010-10-11)
  • Target version changed from 1.2 to 88

#3 Updated by Tuukka Lehtonen about 7 years ago

  • Target version deleted (88)

#4 Updated by Tuukka Lehtonen over 6 years ago

  • Target version set to Simantics 1.5

#5 Updated by Tuukka Lehtonen over 6 years ago

  • Story points set to 3

#6 Updated by Tuukka Lehtonen over 6 years ago

  • Priority changed from 2 to 6

#7 Updated by Tuukka Lehtonen over 6 years ago

  • Assignee changed from Antti Villberg to Tuukka Lehtonen

#8 Updated by Tuukka Lehtonen over 6 years ago

  • % Done changed from 0 to 100
  • Estimated time set to 0.00

Fixed in r21334.

#9 Updated by Tuukka Lehtonen over 6 years ago

  • Status changed from In Progress to Resolved
  • 20 set to 8

#10 Updated by Kalle Kondelin over 6 years ago

  • Status changed from Resolved to Closed

#11 Updated by Tuukka Lehtonen over 6 years ago

  • Tracker changed from Bug to Task
  • Project changed from Simantics to Platform
  • Category deleted (org.simantics.browsing.ui)

#12 Updated by Tuukka Lehtonen over 6 years ago

  • Parent task set to #2801

#13 Updated by Tuukka Lehtonen over 6 years ago

  • Subject changed from Model browser selection does not work always correctly. to Fix graph explorer selection to work when selected data is removed

Also available in: Atom PDF