Enhancement #5423

Deterministic source ordering for Annotation selection tab

Added by Tuukka Lehtonen over 3 years ago. Updated over 3 years ago.

Status:ClosedStart date:2014-10-19
Priority:4Due date:2014-11-07
Assignee:Tuukka Lehtonen% Done:

100%

Category:AnnotationsSpent time:2.00 hours
Target version:1.13.4
Release notes:Changed Annotations property tab to always show annotation sources in the same order (Component, Element) if there are many sources
Tags: selection, annotation
Story points-
Velocity based estimate-
ReleaseSimantics 1.13.4Release relationshipAuto

Description

The Annotation selection view tab annotation source combo box data order currently depends on the input received. The selection view framework always calculates selection tabs and their inputs in a random order and this is currently rather difficult to change. For example, regardless of whether the user selects a configuration component from the model browser or a diagram element source:foundation/browsing/trunk/org.simantics.selectionview/src/org/simantics/selectionview/StandardSelectionProcessor.java will calculate both inputs the configuration component and the mapped diagram element Variable and then create an Annotation org.simantics.selectionview.TypedVariableTabContributor for both of these inputs. The order of the tab contributions will be random and there's currently no clear way of prioritizing the inputs since StandardSelectionProcessor treats them as plain Objects.

Due to these circumstances, this issue changes the annotation view source calculation to always produce result in the order (Component, Element).


Related issues

Related to Platform - Support #5409: 1.13.4 release engineering Closed 2014-10-16 2014-10-17

Associated revisions

Revision 30456
Added by Tuukka Lehtonen over 3 years ago

Changed annotation SCL functions to return available annotation sources always in the same order regardless of the original input (configuration component or diagram element).
StandardSelectionProcessor can't guarantee anything about contribution/input order right now so these changes work around the ordering problem.

refs #5423

Revision 30458
Added by Tuukka Lehtonen over 3 years ago

Merged trunk@-c 30456 to branches/simantics-1.13 on 2014-10-19 for 1.13.4 release.

refs #5409
refs #5423

History

#1 Updated by Tuukka Lehtonen over 3 years ago

  • Status changed from In Progress to Feedback
  • % Done changed from 0 to 100

#2 Updated by Tuukka Lehtonen over 3 years ago

  • Target version changed from 1.17.1 to 1.13.4
  • Release changed from 16 to 22

#3 Updated by Tuukka Lehtonen over 3 years ago

  • Status changed from Feedback to Closed

#4 Updated by Tuukka Lehtonen over 3 years ago

  • Release notes set to Changed Annotations property tab to always show annotation sources in the same order (Component, Element) if there are many sources

Also available in: Atom PDF