Enhancement #4570

Allow simulator variable NodeManager to return classifications for nodes

Added by Tuukka Lehtonen about 4 years ago. Updated about 4 years ago.

Status:ClosedStart date:
Priority:4Due date:
Assignee:Tuukka Lehtonen% Done:

100%

Category:VariableSpent time:1.50 hour
Target version:1.13.1
Release notes:
Story pointsS
Velocity based estimate-
ReleaseSimantics 1.13.2Release relationshipAuto

Description

It would be useful if simulator variable implementations could also provide their own contribution to how the simulator variable nodes are classified, similarly to Variable.getClassifications.

Currently the standard Variable.getClassifications implementations only know how to return results when the variable is backed by a database Resource representation.

The goal here is to change the standard logic to execute in the following order:
  1. if the variable has a resource and its classification is non-empty, return the resource classification
  2. if the variable has a simulator variable node, return the simulator variable's classification
  3. return empty classifications

Associated revisions

Revision 28397
Added by Tuukka Lehtonen about 4 years ago

Added a new method to the simulator variable NodeManager interface to complement the functionality of Variable.getClassifications:
Set<String> getClassifications()

Changed StandardGraphChildVariable to try the simulator variable node as a secondary measure for retrieving variable classifications.

fixes #4570

History

#1 Updated by Tuukka Lehtonen about 4 years ago

  • Description updated (diff)
  • Category set to Variable
  • Status changed from New to In Progress
  • Assignee set to Tuukka Lehtonen

#2 Updated by Tuukka Lehtonen about 4 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100

Applied in changeset r28397.

#3 Updated by Tuukka Lehtonen about 4 years ago

Applied in changeset r28397.

#4 Updated by Tuukka Lehtonen about 4 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF