Enhancement #4564

ResourceEditorInput rehaul - replace model URI with rid

Added by Antti Villberg about 4 years ago. Updated almost 4 years ago.

Status:ClosedStart date:
Priority:4Due date:
Assignee:-% Done:

100%

Category:-Spent time:-
Target version:1.13.1
Release notes:
Story pointsS
Velocity based estimate-
ReleaseSimantics 1.13.2Release relationshipAuto

Associated revisions

Revision 28383
Added by Antti Villberg about 4 years ago

Get rid of model URI in inputs
refs #4564

Revision 28391
Added by Antti Villberg about 4 years ago

ResourceEditorInput2 RVI is now from RVI.toString
refs #4564

Revision 28401
Added by Antti Villberg about 4 years ago

Removed prints
refs #4564

Revision 28406
Added by Tuukka Lehtonen about 4 years ago

Safer RuntimeVariable request.
refs #4564

Revision 28458
Added by Tuukka Lehtonen about 4 years ago

Fixed input RVI handling error in SpreadsheetEditor2.
refs #4564

Revision 28467
Added by Tuukka Lehtonen about 4 years ago

Fixed problems that occur in situations where editor input data is removed/broken:
  • ResourceEditorInput2.assertExists more properly spots broken inputs instead of throwing unexpected exceptions
  • RuntimeDiagramManager/RuntimeVariable/RuntimeVariableForInput uses Resource model / RVI rvi instead of String arguments where possible and handles missing/broken inputs better than before.
  • ActiveRuns request was made a bit safer by using Variables.getPossibleVariable instead of Variables.getVariable when the input resource may be invalid when this request is executed.

refs #4564

Revision 28475
Added by Tuukka Lehtonen about 4 years ago

Removed bogus super.equals invocation from RVI.equals. RVI is a Bean class but still this super-call is redundant and it seems broken also for some reason.
An RVI is identified by it's class and its parts, nothing else.

refs #4564

Revision 28476
Added by Tuukka Lehtonen about 4 years ago

Fixed obvious flaw in previous change r28475.

refs #4564

Revision 28510
Added by Tuukka Lehtonen about 4 years ago

Fixing a lot of RVI based editor input calculations that involve model resource and RVI construction.
The old code was using class StructuralVariables which is a rather deprecated piece of junk and should no longer be used.
I've now deprecated the whole class. Please refrain from using it and use variables and Variables class methods instead.

refs #4564

Revision 28895
Added by Tuukka Lehtonen about 4 years ago

Fixed broken ResourceEditorInput2.getVariable(ReadGraph).
refs #4564

Revision 28898
Added by Tuukka Lehtonen about 4 years ago

Fixed EditorNamingService and AnnotationTypeEditorNamingService to work with:
  1. NameLabelUtil.modalName
  2. IResourceEditorInput2.getRVI

refs #4564

History

#1 Updated by Antti Villberg about 4 years ago

  • Status changed from New to In Progress

#2 Updated by Tuukka Lehtonen about 4 years ago

Just to note: there are still many places in the codebase that invoke the String RVI constructor of ResourcEditorInput2. Most of these have invalidly constructed the RVI string by using a plain name representation instead of the resource notation.

#3 Updated by Tuukka Lehtonen about 4 years ago

  • Status changed from In Progress to Resolved

#4 Updated by Tuukka Lehtonen about 4 years ago

  • Status changed from Resolved to Closed

#5 Updated by Tuukka Lehtonen almost 4 years ago

  • % Done changed from 0 to 100

Also available in: Atom PDF