Feature #3883

DiagramViewer's EditorState limits states to hard-coded ones.

Added by Marko Luukkainen over 5 years ago. Updated over 1 year ago.

Status:On holdStart date:
Priority:4Due date:
Assignee:-% Done:

0%

Category:-Spent time:-
Target version:-
Release notes:
Story points-
Velocity based estimate-

Description

EditorState class and its handling limits the states:
1. org.simantics.modeling.ui.diagramEditor.DiagramEditorStates uses only EditorState, inheritance is not possible.
2. EditorState.toToolMode() is hard-coded to support Pointer, Pan, and Connect tools.
3. Creating new tools / states in own editor causes DiagramViewer.applyEditorStates to fail without overloading the said method. 1. causes cumbersome code in overloaded method, and 2. makes EditorState.toToolMode() an unusable method.

Steps to fix:
1. EditorState class must be changed to an interface.
2. DiagramEditorStates must use ReadGraph.adapt() to instantiate EditorState implementations.

History

#1 Updated by Tuukka Lehtonen over 1 year ago

  • Start date deleted (2012-11-28)
  • Release set to 43

#2 Updated by Tuukka Lehtonen over 1 year ago

  • Release deleted (43)

#3 Updated by Tuukka Lehtonen over 1 year ago

  • Status changed from New to On hold

Also available in: Atom PDF